Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

embed function API should be explicit #33

Open
tpgillam opened this issue Feb 9, 2024 · 0 comments
Open

embed function API should be explicit #33

tpgillam opened this issue Feb 9, 2024 · 0 comments

Comments

@tpgillam
Copy link
Collaborator

tpgillam commented Feb 9, 2024

Currently we define the embed function in embed.jl that converts multiple algebras into GA44.

Other embeddings are presumably possible, so I think it would be better for it to take the multivector type into which it will embed.

At this point we should consider whether defining Base.convert would be appropriate, rather than creating a new function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tpgillam