Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create water shaders options #163

Open
TheDuckCow opened this issue Oct 18, 2020 · 12 comments
Open

Create water shaders options #163

TheDuckCow opened this issue Oct 18, 2020 · 12 comments
Labels
enhancement Feature requests or new functionality suggestions

Comments

@TheDuckCow
Copy link
Member

This was actually already partially implemented, but then disabled in the last release to refine further. The goal is to provide out of the box options for water shaders. This would appear as yet another dropdown in the prep materials popup (although this popup is really getting cluttered now, another matter to consider). This would also be included in the settings for swap resource pack and generate materials from the material library panel. Different options could include:

  • Default prep (ie nothing special, only animate if animate textures enabled)
  • Animated reflective (using 4D texture noise and overlaps), little transparency
  • Animated reflective, higher transparency

Worth reaching out and seeing what shaders the community has created and used.

@TheDuckCow TheDuckCow added the enhancement Feature requests or new functionality suggestions label Oct 18, 2020
@StandingPadAnimations
Copy link
Collaborator

I think it would be a cool feature to add, especially if the water shader is simple and easy to add more to(since it would encourage people to learn nodes and make tweaks)

@TheDuckCow TheDuckCow added this to the v3.3.1 milestone Jan 5, 2022
@NiskoDT
Copy link

NiskoDT commented Feb 12, 2022

So here is my node setup for my water. Also I included 2 renders.
image
githubsubmit
githubsubmit1

@StandingPadAnimations
Copy link
Collaborator

Looks nice. I think the mapping nodes can be removed for Blender versions that have 4D noise textures. Also, it may be possible to use geometry nodes to add fake caustics which would benefit EEVEE (example: https://www.youtube.com/watch?v=C9iQKsShYIM) and Cycles if it doesn't gain MNEE

@StandingPadAnimations
Copy link
Collaborator

My concern however is the use of glass. In Blender, glass doesn't tend to look good if caustics are disabled, which is common in MC animation (for render time and noise reasons). Though this could be avoided with some transparency sorcery

@NiskoDT
Copy link

NiskoDT commented Feb 15, 2022

So I did remove the mapping node, and then turns out its still needed to scale down the waves size, because using the "scale" value on one of the either noise texture doesnt seem to look good. Also, the two renders that I give actually has a different scale, the bottom one is lower than the top one. Also, since it is connected to the "Object" mapping, before it was the "UV", but it messes with a mesh that has diifferent face size. Also, I was thinking that, should I make it into a group node? Because I think its better if I make it into a group node, so its easier to change the value.

@TheDuckCow
Copy link
Member Author

Thanks everyone for the commentary in this thread! My reply is quite overdue - I'm going to shift this to the 3.4 release in favor of a sooner release of 3.3.1, which itself is quite overdue. Will likely seek feedback closer to the next release as I try to code in some options here.

@TheDuckCow TheDuckCow modified the milestones: v3.3.1, v3.4.0 Apr 14, 2022
@TheDuckCow TheDuckCow modified the milestones: v3.4.0, v3.4.1 Jul 10, 2022
@TheDuckCow TheDuckCow modified the milestones: v3.4.2, v3.4.3 Jan 30, 2023
@TheDuckCow
Copy link
Member Author

As per tradition :/ kicking this down the road, as we need to get v3.5.0 out the door soon.

@TheDuckCow TheDuckCow modified the milestones: v3.5.0, v3.5.1 Jul 5, 2023
@StandingPadAnimations
Copy link
Collaborator

I have an RTX style water shader that MCprep can use if needed, it's public domain (well the material, not the water texture)

https://standingpadanimations.github.io/resources/#rtx-style-water-shader-v2

@TheDuckCow
Copy link
Member Author

The shader part is "easy", more about making sure we create the right user experience for being able to select it. Not that it's a huge effort, just need to give it the proper time, and not worth delaying v3.5.0 - appreciate the shader though, that seems like a great thing to include once we work on this!

@NiskoDT
Copy link

NiskoDT commented Jul 5, 2023

My concern however is the use of glass. In Blender, glass doesn't tend to look good if caustics are disabled, which is common in MC animation (for render time and noise reasons). Though this could be avoided with some transparency sorcery

Lol after a year I finally understand this reply. So yeah glass isn't necessary, I actually followed a tutorial and decided to tweak it to my liking, and since I always have caustics enabled in my renders.

As for mapping nodes, I think that, for me atleast, messes up the scaling of the textures if it's not present.

@NiskoDT
Copy link

NiskoDT commented Jul 5, 2023

The shader part is "easy", more about making sure we create the right user experience for being able to select it. Not that it's a huge effort, just need to give it the proper time, and not worth delaying v3.5.0 - appreciate the shader though, that seems like a great thing to include once we work on this!

Ah I keep forgetting that there are people that still use 2.7 and anything below 3.0. If user experience is the key point, I was suggesting using the "Asset Browser", so then they can drag and drop the material to the object. But if there are still using versions below 3.0, then probably not

@zNightlord
Copy link
Contributor

Ah I keep forgetting that there are people that still use 2.7 and anything below 3.0. If user experience is the key point, I was suggesting using the "Asset Browser", so then they can drag and drop the material to the object. But if there are still using versions below 3.0, then probably not

#414, that introduce some "drag" operators depend on the newer MCprep UI tabs (Materials, Blocks/Meshswap, Mob/entity rigs) so yes, changing some of the current known UI for 3.0+

@TheDuckCow TheDuckCow modified the milestones: v3.5.1, v3.5.2 Nov 15, 2023
@StandingPadAnimations StandingPadAnimations removed this from the v3.5.3 milestone Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or new functionality suggestions
Projects
Status: Backlog
Development

No branches or pull requests

4 participants