Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force blender restart if update detected #402

Closed
TheDuckCow opened this issue Mar 19, 2023 · 4 comments · Fixed by #407
Closed

Force blender restart if update detected #402

TheDuckCow opened this issue Mar 19, 2023 · 4 comments · Fixed by #407
Labels
enhancement Feature requests or new functionality suggestions
Milestone

Comments

@TheDuckCow
Copy link
Member

If we detect an update occurred, either due to a manual install or the automated installer, we should force the user to restart blender by only showing "Updated, restart blender" in the MCprep panel.

Alternatively to this, we could explore triggering the "reload all scripts" function, though that affects all scripts and not just MCprep.

This will help eliminate the issues that get reported around updating due to people not restarting, while also helping users actually avoid problems in the first place.

@TheDuckCow TheDuckCow added this to the v3.4.3 milestone Mar 19, 2023
@TheDuckCow TheDuckCow added the enhancement Feature requests or new functionality suggestions label Mar 19, 2023
@TheDuckCow TheDuckCow linked a pull request Mar 25, 2023 that will close this issue
@TheDuckCow
Copy link
Member Author

This video shows the final functionality in practice (FYI to @StandingPadAnimations who I've marked as a reviewer):

demo_restarting.mp4

@StandingPadAnimations
Copy link
Collaborator

I find every panel telling the user to restart Blender absolutely hilarious

@TheDuckCow
Copy link
Member Author

ha yeah it does feel a bit excessive, but certainly gets the point across.

Another option I suppose would be to have all other panels conditionally not appearing. Normally I don't like appearing and disappearing panels (it's very unintuitive for users), but in this case it would actually be reasonable I suppose. What do you think, worth the change?

@StandingPadAnimations
Copy link
Collaborator

I think it would be a much better idea. It also means we could add more information like "Restarting Blender is a must for updates to properly apply and not cause issues"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or new functionality suggestions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants