Forcing users to restart if there is any update detected. #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies to both manual as well as addon-updater updates. The reason for this change is to avoid errors that will happen in future versions when we rename modules, remove functions, and generally revamp the structure of MCprep. Many users encounter errors due to not restarting Blender already, even with 'typical' updates.
| @@ -845,6 +903,10 @@ class MCPREP_PT_bridge(bpy.types.Panel): | |||
| bl_category = "MCprep" | |||
|
|
|||
| def draw(self, context): | |||
| if addon_just_updated(): | |||
There was a problem hiding this comment.
It would be nice if there was a short comment above these explaining what they do for any future developers
There was a problem hiding this comment.
Do you think it's sufficient to have that comment in the code of those functions? Otherwise we'll be having copies of the comment in 10x places, adding to the boilerplate.
There was a problem hiding this comment.
Should be fine as long as it's explained what the functions do and why they do that they do
There was a problem hiding this comment.
So... would you modify the docstrings that are there now I guess is the question :)
StandingPadAnimations
requested changes
Mar 25, 2023
StandingPadAnimations
approved these changes
Mar 25, 2023
|
Looks good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies to both manual as well as addon-updater updates. The reason for this change is to avoid errors that will happen in future versions when we rename modules, remove functions, and generally revamp the structure of MCprep. Many users encounter errors due to not restarting Blender already, even with 'typical' updates.
closes #402