Effects spawning #299
Effects spawning #299
Conversation
Also moves to stricter enum matching for references to avoid typos. Placeholders for other effects spawner types.
Want to ensure we don't accidentally change this file unless intentional, tracking using lfs enables this
Allows to optionally yet generally define a way to set inputs for particular node inputs, and have multiple presets to define an effect while reusing the same geometry nodes. Sample file checked in, but will be updated after getting feedback from geonodegroup owner on the ideal settings
…ive collection for new objs
Also moves to stricter enum matching for references to avoid typos. Placeholders for other effects spawner types.
Want to ensure we don't accidentally change this file unless intentional, tracking using lfs enables this
Allows to optionally yet generally define a way to set inputs for particular node inputs, and have multiple presets to define an effect while reusing the same geometry nodes. Sample file checked in, but will be updated after getting feedback from geonodegroup owner on the ideal settings
…ive collection for new objs
|
Hey @StandingPadAnimations - no obligation, but if you have time and would like to, would love to have you glance through and see if things look good from your standpoint. If you don't have time no worries, I'll just merge. |
MCprep_addon/spawner/effects.py
Outdated
| # ----------------------------------------------------------------------------- | ||
|
|
||
|
|
||
| def create_auto_footfall_particle_plane(): |
There was a problem hiding this comment.
Seems like this doesn't do much. It may be best to comment this out so Python doesn't have to create a function object
There was a problem hiding this comment.
Fair call - better to make it an enhancement issue vs deadcode, removed in the meantime.
MCprep_addon/spawner/effects.py
Outdated
|
|
||
| # Importer helper | ||
| filter_glob = bpy.props.StringProperty( | ||
| default="*.png;*.jpg;*.jpeg;*.tiff", |
There was a problem hiding this comment.
Is there a way to take advantage of the EXTENSIONS variable for this?
There was a problem hiding this comment.
Good idea, I've made the update now.
| @@ -1513,6 +1519,161 @@ def model_spawner(self): | |||
| # Test collection/group added | |||
| # Test loading from file. | |||
|
|
|||
| def geonode_effect_spawner(self): | |||
| """Test the geo node variant of effect spawning works.""" | |||
| if bpy.app.version < (3, 0): | |||
There was a problem hiding this comment.
I think we need a maxBv function similar to the minBv function added alongside the optimizer. It has a benefit of also being cacheable, something that would help a lot
There was a problem hiding this comment.
Good catch to ask about this function. I don't think a maxBv is needed, as we can take any min bv and just inver the logic. You can see the change I made in this commit.
|
if you don't mind, I'll be pushing a few commits to this branch |
|
Actually most of the changes should be added once this is merged (mainly within util.py) |
|
Thanks for the review @StandingPadAnimations, super nice to get another set of eyes and feedback on these things. I'm going to merge in the meantime to dev. |
No description provided.