Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add effects to user preferences and advanced option #339

Merged
merged 4 commits into from
Oct 16, 2022

Conversation

zNightlord
Copy link
Contributor

@zNightlord zNightlord commented Aug 25, 2022

For certain user want to change the effect path to another location through preferences and through the advanced dropdown and resolve the symlink issue, user created or when the addon added through vscode debug extension. #338

I'm not sure about adding reset path for consistency.

@TheDuckCow TheDuckCow self-requested a review September 15, 2022 21:13
Copy link
Member

@TheDuckCow TheDuckCow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for the contribution! (and apologies for the delayed reply)

@TheDuckCow TheDuckCow changed the base branch from master to dev September 15, 2022 21:14
@TheDuckCow TheDuckCow linked an issue Sep 15, 2022 that may be closed by this pull request
2 tasks
@TheDuckCow
Copy link
Member

Merging this, thanks again

@TheDuckCow TheDuckCow merged commit 7d48728 into Moo-Ack-Productions:dev Oct 16, 2022
@TheDuckCow TheDuckCow added this to the v3.4.2 milestone Oct 16, 2022
@zNightlord zNightlord deleted the effects-preferences branch December 7, 2022 15:51
@zNightlord zNightlord restored the effects-preferences branch December 7, 2022 15:51
@zNightlord zNightlord deleted the effects-preferences branch December 7, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Effects folder directory preferences
2 participants