Using the C++ OBJ importer and Fixing Issues with Importing when using a Non-standard colorspace #373
Conversation
|
Ok we should start weighing the tradeoffs of using the C++ OBJ importer for 3.1 - 3.4, since feature wise the C++ importer loses a major feature (split groups) that was only added in 3.5 |
|
I think I'll keep it enabled in 3.1 - 3.4. The loss of functionality is made up for by the massive performance improvements. I've noticed with even small OBJs the performance goes from seconds to instant imports, so who knows how this scales |
|
That's really awesome to hear. In terms of splitting the world back into by material, we could just run that function on import (that was the actual reason for using an custom operator for import, in the early days of 2.8 when everything was joined together). It will bring back a little bit of that slowness, but might still be worth it. Thanks a ton for this, will try to get to review this. The imminent release urgency dropped as my tutorial sequence is not blocked on the need to fix sync materials (that still should be fixed tho). Will try to review this and your other change soon. |
When MCprep opens the file picker, both OBJs and MTLs can be selected, which was annoying when accidently selecting the MTL file of the OBJ. This adds a quality of life improvement by replacing .mtl with .obj if the user accidently clicks the MTL file
MTL files need to be edited in order for OBJ importing to work properly when using a non-standard colorspace like ACES or AgX. Of course, editing MTL files and then reverting the edits can be error prone, and if done wrong the user won't be able to retrieve the original MTL. This can be fixed by creating a new folder called "ORIGINAL_MTLS" with pathlib, and then copying the MTL to that new folder before editing. Now that the original is backed up, we don't need to revert edits. Of course the editing section will still run regardless of there's edits or not, so we'll need to look into checking if an edit was made (perhaps by comparing timestamps).
|
Alright, MTL files should now be copied to a new folder called |
StandingPadAnimations
force-pushed
the
support-all-color-management
branch
from
437749f
to
8b7535b
Compare
|
Weird situation: Not sure why but somehow Kaion's master branch was merged with |
|
Ight, I still haven't found the reason for this, so sadly I'll have to close this for now Seems like Github did something to the remote repo that caused this issue |
|
Ok so turns out when I forced reverted the merge commit, it didn't properly revert the merge. I'll look into reverting the force push (Github thankfully stored the commit in question) @TheDuckCow do you know how to properly undo a merge? |
|
Ok so I've reverted the merge. Sadly the history remains but oh well. I'll continue to see if I can remove the extra commits that were introduced, but hopefully this should be fine now |
|
Good news, I've split this into 2 branches, and with some cherrypicking was able to move some commits over. I still need to reimplement MTL conversion but #382 now tracks support for the new C++ OBJ importer |
|
Alright, I've now restored both changes, and they have their own PRs |
This comes at the cost of having a split OBJ, but it solves 2 issues:
Perhaps we could put this behind a user prefs option, so users can use the legacy importer if they need to (though idk what stops a user from going into edit mode, selecting the OBJ, and splitting by material)