Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desaturation fix #374

Merged
merged 3 commits into from
Mar 6, 2023
Merged

Desaturation fix #374

merged 3 commits into from
Mar 6, 2023

Conversation

StandingPadAnimations
Copy link
Collaborator

As mentioned in #368 (comment), the desaturation bug that's been recently plaguing MCprep for a while is caused by using an incorrect index. This PR should hopefully fix it (fingers crossed, I haven't tested it yet)

@StandingPadAnimations StandingPadAnimations linked an issue Feb 21, 2023 that may be closed by this pull request
Fix desaturation check with new mix node #368
Closed
TheDuckCow
TheDuckCow requested changes Feb 22, 2023
View reviewed changes
Copy link
Member

@TheDuckCow TheDuckCow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix to make, spot check the value and consider using the more generic selector

MCprep_addon/materials/generate.py Outdated Show resolved Hide resolved
@StandingPadAnimations
Copy link
Collaborator Author

StandingPadAnimations commented Feb 23, 2023 •
edited
Loading

Made the necessary change. get_node_socket returns a list, so I think the code was originally meant to access index 2 of that list (which would indeed be index 7 of the Mix node), but accidentally accessed index 2 of the Mix node

@TheDuckCow TheDuckCow self-requested a review March 6, 2023 14:06
TheDuckCow
TheDuckCow approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@TheDuckCow TheDuckCow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go - please merge at your earliest convenience!

@StandingPadAnimations StandingPadAnimations merged commit 4b1dc50 into Moo-Ack-Productions:dev Mar 6, 2023
@StandingPadAnimations StandingPadAnimations deleted the desaturation-fix branch March 7, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheDuckCow TheDuckCow TheDuckCow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix desaturation check with new mix node
2 participants
@StandingPadAnimations @TheDuckCow