Fix MTL conversion bug with Mineways MTLs #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's been a issue recently where Mineways will name MTLs weirdly. For instance: - "Beach Town.obj" : "Beach_Town.mtl" - "hello there.obj" : "hello_there.mtl" The MTL conversion function simply replaces the extension of self.filepath, assuming that the MTL has the same name. However, since Mineways adds underscores, convert_mtl would throw an exception when attempting to read the file. The current workarounds are to: - Remove the underscores - Don't add spaces to OBJ names (ideally no one should be adding spaces to any filename because of issues like this) - Use jmc2OBJ, which as far as I know doesn't have this weird behavior This is more of a band-aid, and ideally we should check for underscores in the MTL name (we can take advantage of pathlib for this), but for now if an exception occurs due to a weirdly named MTL, we'll just print the error, return False, and call it a day.
TheDuckCow
requested changes
Mar 15, 2023
There was a problem hiding this comment.
Hey, am I reading this right, that this would be causing complete import errors for a large swath of users? If so, we might need to do an emergency patch release. Unfortunately my error analytics pipeline slightly broke so we're flying blind for a couple days until I fix that (cloud related issue only).
I also should have thought to error handle that and later lines.
By taking advantage of the pathlib module (Seriously, why don't we use it more? It makes file operations so much easier and is compatible with the os module), we check to see if the assumed MTL path is valid. If not, we then replace the spaces in the MTL filename with underscores. If still not, then we return False. This assumes that an MTL will always have either the same name as the corresponding OBJ, or that Mineways went ahead and added underscores.
TheDuckCow
approved these changes
Mar 17, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's been a issue recently where Mineways will name MTLs weirdly. For instance:
The MTL conversion function simply replaces the extension of self.filepath, assuming that the MTL has the same name. However, since Mineways adds underscores, convert_mtl would throw an exception when attempting to read the file. The current workarounds are to:
spaces to any filename because of issues like this)
behavior
This is more of a band-aid, and ideally we should check for underscores in the MTL name (we can take advantage of pathlib for this), but for now if an exception occurs due to a weirdly named MTL, we'll just print the error, return False, and call it a day.