Update compile.sh: quoted variables behind rm commands #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dAnimations-patch-1
Dev to master for v3.4.3
Just a precaution, considering. Any hidden bugs involving word splitting or pathname expansion could be obviated just by adding double quotes to variable and array references.
|
Thanks for flagging - cc @StandingPadAnimations to edit to be based onto the best appropriate branch (would this be dev, or the milestone-3-5-0?) |
|
Milestone would be preferable as that's where all compile.sh changes are going (and it's our build system till #422 is merged) |
TheDuckCow
approved these changes
Jul 4, 2023
|
I'll merge this on your behalf, shouldn't have taken us this long to approve such a straightforward change, thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a precaution, considering. Any hidden bugs involving word splitting or pathname expansion could be obviated just by adding double quotes to variable and array references.