Merging the Milestone 3.5. refactor #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we're dropping 2.7x support, this is no longer needed. Most of the compatability functions will remain though since they're more readable.
Replaced some instances of os.path with the Path object from pathlib for readability. Also added type annotations to MCprepEnv as we're moving towards that. This also means MCprep will not work at all in Blender 2.7x due to the use of new syntax. This will be the first in a long process of modernizing MCprep's code with 2.8 style code. Blender 2.7x users may not be happy, but it's for the better. If anything, 6 years worth of 2.7x support was a mistake (in my opinion), as it limited what we could do and opened MCprep to even more bugs (like in Blender 2.93 with make_annotations, which ironically now is deprecated).
Replaced the old = syntax with the new : syntax. This also removes the need for make_annotations, hence why they're removed.
As we're removing 2.7x support, it makes sense to remove Blender Internal compatability as the engine is not present in Blender 2.8 and above. Even UPBGE (a fork of the Blender game engine that's still maintained) uses EEVEE, so there's no reason to continue supporting Blender Internal.
The bang at the top meant Linux users couldn't run the test suite. This changes now allows Linux users to run tests
Deprecation warning function was moved in MCprepEnv since it made more sense to put it there
Originally matprep_cycles used to take multiple arguments, each one representing a seperate option. This was annoying as it meant the function has an unfathomable amount of arguments to keep track of. This has been replaced with a dataclass (called PrepOptions) that keeps track of all the options selected by the user. Not only does it make it slightly easier for developers, it also gives the following benefits: - More info on what types the different options are - Better organization Previously we couldn't do this due to 2.7x support, hence this being in mcprep-3_5-recore.
To avoid polluting output
To avoid polluting output
Dev to master for v3.4.3
I'm honestly not sure how I missed these, but good thing they were caught. Now MCprep shouldn't be dealing with any errors related to env now...
All tests passing, but also created disabled by default tests that have UI triggered popups which would be annoying to have on by default, but are good for code coverage.
…nittest-library Set up new unittest system
Test intentionally does not yet pass, as there's a bug in the code to fix first. Will do so in the next commit.
One reference wasn't using the new system for version-agnostic mix rgb slot selection, that is now fixed and all tests are passing across all versions.
All tests passing, but also created disabled by default tests that have UI triggered popups which would be annoying to have on by default, but are good for code coverage.
Test intentionally does not yet pass, as there's a bug in the code to fix first. Will do so in the next commit.
One reference wasn't using the new system for version-agnostic mix rgb slot selection, that is now fixed and all tests are passing across all versions.
…migrate-unittests
Tests are slower to run now since there's no -fast command, but all tests currently run.
This is to make sure the latest versions of every dependency is installed, as to reduce variables in what could be causing errors.
Migrated initial prep material tests, all currently passing.
|
As a sanity check, current state of tests: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.