Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

399 update deprecated references #473

Merged
merged 4 commits into from
Sep 3, 2023

Conversation

TheDuckCow
Copy link
Member

@TheDuckCow TheDuckCow commented Sep 3, 2023

Will contribute to closing #399

This removes the remaining bv28 code references, used previously to distinguish between 2.8+ and 2.7 code. Along with this, this PR also removes all of this now no-longer relevant 2.7 code, and implements some missing tests for spawners which were also affected. Also removes code referencing layers, since this is only a 2.7x concept.

Also move to use the native user_remap function since this is confidently available now, where before we had an intermediate util used for backwards compatibility.

All tests, including the new ones, passing:

-------------------------------------------------------------------------------
bversion   	ran_tests	ran	skips	failed	errors
-------------------------------------------------------------------------------
(3.6.2)   	all_tests	35	2	0	No errors
(4.0.0)   	all_tests	35	2	0	No errors
(3.5.1)   	all_tests	35	2	0	No errors
(3.4.0)   	all_tests	35	2	0	No errors
(3.3.1)   	all_tests	35	2	0	No errors
(3.2.1)   	all_tests	35	2	0	No errors
(3.1.0)   	all_tests	35	2	0	No errors
(3.0.0)   	all_tests	35	2	0	No errors
(2.93.0)   	all_tests	35	2	0	No errors
(2.90.1)   	all_tests	35	2	0	No errors
(2.80.75)   	all_tests	34	3	0	No errors
tests took 167s to run

It was only necessary to support older versions of 2.7, which is no
longer supported anyways now.
@TheDuckCow TheDuckCow linked an issue Sep 3, 2023 that may be closed by this pull request
@TheDuckCow
Copy link
Member Author

Updated the description, ready for review now.

@TheDuckCow TheDuckCow marked this pull request as ready for review September 3, 2023 05:36
@TheDuckCow TheDuckCow linked an issue Sep 3, 2023 that may be closed by this pull request
Copy link
Collaborator

@StandingPadAnimations StandingPadAnimations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@StandingPadAnimations
Copy link
Collaborator

I'll merge this in now

@StandingPadAnimations StandingPadAnimations merged commit 3778352 into dev Sep 3, 2023
@StandingPadAnimations StandingPadAnimations deleted the 399-update-deprecated-references branch September 3, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to the unittest library Dropping 2.7x support in MCprep 3.5
2 participants