Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed syntax error on line 253 in prep.py #480

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Conversation

StandingPadAnimations
Copy link
Collaborator

Exactly what the title says, I can't push to dev for some reason

@StandingPadAnimations StandingPadAnimations marked this pull request as ready for review September 18, 2023 18:22
Copy link
Contributor

@zNightlord zNightlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to add that to the load material one too since I missed it.

pack_format=self.packFormat,

@StandingPadAnimations
Copy link
Collaborator Author

Alright, I'll merge this, but I've also noticed some other issues with incorrect types, such as like 637 (where a literal is used instead of MCprep_addon.sequences.ExportLocation).

@zNightlord, just curious, does your Python setup catch avoidable type errors like this? If not, I would highly suggest looking into revamping it. While I can try my best to catch these errors during the review process, things will definitely pass through as seen here. I know I sound harsh, but it's easier to catch and fix errors during development rather then fixing them during the last stretch before release (especially now that we can't commit directly to dev anymore)

Copy link
Member

@TheDuckCow TheDuckCow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving.

As per the other thread, I think it's important to not directly push to dev - slightly annoying to always have to use a PR, but mistakes easily happen with "quick fixes" right before releases, I've been there before. Thanks for making the change here, and we'll surely fix other things as we go along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants