Migrating more critical tests ahead of release. #487
Conversation
This includes QA checking scripts, which have already uncovered one issue with one of the updated rigs.
|
Alright, with this I've done testing across versions of blender 2.80 up through and including 4.0. There are some issues that remain, I'll comment on the main dev to main PR branch for those. |
|
Even more tests migrated, and now geo nodes in 4.0+ is working without errors: I realized I hadn't tested sync materials or the UV node tools at all, so I'll need to do a trial run of that later (and possibly migrate those tests too). Still, presume this branch is review-ready. |
This was a weird one. Essentially, running the unittests would always result in the `mcprep_data_update.json` file being renamed to `mcprep_data.json` (and since that file isn't tracked in git, would look like the file was deleted wrt to local changes). This was happening, out of all things, due to this line in the unittest runner: unittest.TestLoader().discover(MODULE_DIR, "*_test.py") This is because the discover command clearly has to attempt loading of the modules it's scanning over, and at some point we import the env module and thus the __init__ code on module load would trigger, resulting in the file rename. By moving the rename into the register function, we ensure it only happens in the context of an addon, which is all we really need for it.
|
Sigh, a couple more tests that I decided to move over now are failing. test_sync_materials;test_uv_transform_detection. Still checking if they are actual failures in code, or just test fixture issues. I have some time in the morning (~8-10hr from now) when hopefully I can finish wrapping this all up. |
Unfortunately, we do still have the issue that the test runner renames the mcprep_data_update.json file, and modifies checked-in mtl files, but we can address this in the future.
The new test runner in python is straight forward enough to use that I feel there is no longer a need for any system-specific shell files.
|
Alright, I'm making it official - we're merging this! 3.5 here we come |
This includes QA checking scripts, which have already uncovered one issue with one of the updated rigs.
Recent run: