Improve release automation with automated test running #490
Conversation
|
For reference, this was the exact script used to generate the initial draft of the MCprep v3.5.0 release (including the local mods of the test runner, so that we could extract an exit code). |
| @@ -0,0 +1,103 @@ | |||
| source venv/bin/activate | |||
There was a problem hiding this comment.
Add a shebang so we know what shell this is compatible with
There was a problem hiding this comment.
Again, since no one wants to take charge with reviewing this, I've reviewed this PR (at least the shell script). I'm basing a lot of my comments off of shellcheck's output (assuming this is also Bash).
There are a couple of things in this script that would be issues in Bash, but not in Zsh (the shell macOS uses as its default). While I assume this is a script meant to be ran with Bash, it would be interesting to make this POSIX compatible (i.e., no Bash, no Zsh, just standard POSIX), but that's not a huge requirement.
Since I'm on break (#481), I won't approve or reject this PR; that should come from someone else on the team 😅
Useful to ensure there is consistency during releases. This still requires local, manual running in the meantime, but would be plausible to further automated with github actions once we are comfortable with it.