Fix block model overlay geometry #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At face value, seems this could still cause some z-fighting issues. Seems to render fine in Eevee, but there's still a problem in cycles on render (in blender 3.6): 
My approval of the PR still stands because this is technically still better than before (we can just remove the overlay geo), but what about just the faces of "overlay" geo, or expanding it slightly to have a slight offset @zNightlord? |
TheDuckCow
approved these changes
Nov 15, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix of this issue: Image
Grass block json
Block like grass block has a small overlay on them
should be treated as a threat causing z fighting and clean it upbut let this one pass.