Fix for blender 4.0 not loading materials #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Am I able to link this pull request to an issue? |
2 tasks
2 tasks
|
Can't do a comprehensive review at the moment, but I've done a quick skim of the changes and it mostly looks good to me |
TheDuckCow
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Thank you for this quick fix! Working well locally.
All local tests passing:
------------------------------------------------------------------------------
bversion ran_tests ran skips failed errors
-------------------------------------------------------------------------------
(3.6.2) all_tests 64 2 0 No errors
(4.0.0) all_tests 64 2 0 No errors
(3.5.1) all_tests 64 2 0 No errors
(3.4.0) all_tests 64 2 0 No errors
(3.3.1) all_tests 64 2 0 No errors
(3.2.1) all_tests 64 2 0 No errors
(3.1.0) all_tests 64 2 0 No errors
(3.0.0) all_tests 64 2 0 No errors
(2.93.0) all_tests 63 3 0 No errors
(2.90.1) all_tests 63 3 0 No errors
(2.80.75) all_tests 62 4 0 No errors
tests took 273s to run, ending with code 0
|
feck. never thought of transmission. Anyone else getting this? |
|
Yeah that could be an oversight, we should create / update our unit tests to include some emission and other varieties of materials to make sure we have better scenario coverage. Will review any PR as soon as it comes through, then will decide when it makes sense to cut another release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blender 4.0s new principled BSDF node broke MCprep compatibility due to the renaming of sockets.
I added a blender version check and used the appropriate socket name to regain compatibility. Tested on blender 3.3.9 and blender 4.0.0 stable release, on linux.