Remove references deprecated in MCprep 3.5 #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the deprecated conf.py references that were meant to be removed in MCprep 3.5.1, but weren't due to Blender 4.0's release
TheDuckCow
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
Confirmed all tests still passing, so unlikely any forgotten references
-------------------------------------------------------------------------------
bversion ran_tests ran skips failed errors
-------------------------------------------------------------------------------
(3.6.2) all_tests 63 2 0 No errors
(4.0.2) all_tests 63 2 0 No errors
(3.5.1) all_tests 63 2 0 No errors
(3.4.0) all_tests 63 2 0 No errors
(3.3.1) all_tests 63 2 0 No errors
(3.2.1) all_tests 63 2 0 No errors
(3.1.0) all_tests 63 2 0 No errors
(3.0.0) all_tests 63 2 0 No errors
(2.93.0) all_tests 62 3 0 No errors
(2.90.1) all_tests 62 3 0 No errors
(2.80.75) all_tests 61 4 0 No errors
tests took 281s to run, ending with code 0
|
Alright, then I'll merge the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated conf.py references that were meant to be removed in MCprep 3.5.1, but weren't due to Blender 4.0's release.
Most of these are related to the transition from global variables in
conf.pyto a proper global state withMCprepEnvand theenvvariable, but some also deal with ending 2.7X support, such asmake_annotationsorbv28(althoughbv28's removal could be delayed if we haven't removed all uses of it yet)