Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme and resources update #528

Merged
merged 2 commits into from Jan 4, 2024
Merged

Readme and resources update #528

merged 2 commits into from Jan 4, 2024

Conversation

TheDuckCow
Copy link
Member

No functional changes, routine auto updates and text improvements.

@TheDuckCow TheDuckCow changed the title Doc and resources update Readme and resources update Jan 4, 2024
@TheDuckCow TheDuckCow merged commit 9555ea5 into master Jan 4, 2024
@TheDuckCow TheDuckCow deleted the doc-and-resources-update branch January 4, 2024 04:17
@TheDuckCow
Copy link
Member Author

TheDuckCow commented Jan 4, 2024

Welp, so much for being a safe update. Apparently minecraft renamed grass ie upright grass texture) to colormap/grass and on top of that, for some reason the texture isn't getting saturated/color tinted like it should. Being such a central texture, used for meshswapping.

It means we need to decide whether to rename the actual texture / object name within meshswap for grass, or whether to create an inserted fake mapping for that object in our mapping file. I need to contemplate this.

Edit: The two tests broken by this are test_meshswap_world_mineways_separated (subtest [grass]) and test_canonical_test_mappings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant