Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating grass canonical mapping and improved desaturation debug prints #529

Merged
merged 1 commit into from Jan 6, 2024

Conversation

TheDuckCow
Copy link
Member

With this, we now have correct prep material saturation again for this grass object, and all tests passing again.

Yes, this is intentionally a branch going into master, as I've already merged other work there. This should hopefully be the last change to merge for the 3.5.2 release.

Will let this sit overnight and review tomorrow with fresh eyes. Test results now:

-------------------------------------------------------------------------------
bversion   	ran_tests	ran	skips	failed	errors
-------------------------------------------------------------------------------
(3.6.2)   	all_tests	64	2	0	No errors
(4.0.2)   	all_tests	64	2	0	No errors
(3.5.1)   	all_tests	64	2	0	No errors
(3.4.0)   	all_tests	64	2	0	No errors
(3.3.1)   	all_tests	64	2	0	No errors
(3.2.1)   	all_tests	64	2	0	No errors
(3.1.0)   	all_tests	64	2	0	No errors
(3.0.0)   	all_tests	64	2	0	No errors
(2.93.0)   	all_tests	63	3	0	No errors
(2.90.1)   	all_tests	63	3	0	No errors
(2.80.75)   	all_tests	62	4	0	No errors

With this, we now have correct prep material saturation again for this
grass object, and all tests passing again.
@TheDuckCow TheDuckCow added this to the v3.5.2 milestone Jan 4, 2024
@TheDuckCow TheDuckCow merged commit efbb78f into master Jan 6, 2024
@TheDuckCow TheDuckCow deleted the fix-updated-mc-mapping-consequences branch January 6, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant