Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding material no_prep properties #561

Merged

Conversation

zNightlord
Copy link
Contributor

This is a part of #440 splitted into many PRs.
This first introduce MCPREP_NO_PREP properties under material, this is useful for material doesn't want MCprep prep material overwrites it like on some rigs have been defined in the json file "mob_skip_prep".

Additional question:

  • Should there an option on prep material to force prepping this skipped no prep?

image

@StandingPadAnimations
Copy link
Collaborator

I don't think an option for force prep is needed. Assuming it's a user override, that should be respected always

@zNightlord
Copy link
Contributor Author

I don't think an option for force prep is needed. Assuming it's a user override, that should be respected always

I'm just thinking about the case where you decide need prep material but have to go though each of them set it to 0 so.

@StandingPadAnimations
Copy link
Collaborator

StandingPadAnimations commented Apr 15, 2024

Eh, I'd imagine the user would know what materials they've set MCPREP_NO_PREP on. Maybe that could be better solved with some UI design to remind the user which materials have no-prep? That might cause some cluttering though, so I'll tag @TheDuckCow on that

@StandingPadAnimations
Copy link
Collaborator

Overall I think we could put this under #274 (which I've been meaning to discuss more on for MCprep 4.0) and take a look at it later once we know how everything in a revamped system would fall in place

Copy link
Member

@TheDuckCow TheDuckCow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor change requested, but once I see it I'd be happy to approve this as is. I don't see a reason to wait for something like this, and I actually like it better than the json approach we've been using so far (centrally defining rig names for checkups is kind of gross). I don't think this will interfere with the new material system planned, they can both coexist in my mind.

MCprep_addon/materials/prep.py Outdated Show resolved Hide resolved
Copy link
Member

@TheDuckCow TheDuckCow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks for the change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants