Fix OFFSET-FETCH clause problem for MS SQL Server prior to 2012 #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
override ConstructFullSelectStatementInternal() to avoid OFFSET-FETCH clause which is supported from SQL Server 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current MsSqlBuilder class generate SQL statement for paging search with OFFSET-FETCH clause, which is only supported by SQL Server from 2012 edition. (see also: https://docs.microsoft.com/en-us/sql/t-sql/queries/select-order-by-clause-transact-sql#Offset) Therefore, we need a separate SqlBuilder class and dialect enum item for SQL Server prior to 2012.
relevant issue: #85