Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings - manage wallet, reveal secret phrase #214

Merged
merged 9 commits into from Dec 5, 2019
Merged

Conversation

@NovacAndrei
Copy link
Contributor

NovacAndrei commented Dec 4, 2019

Also fix:

  • header style
  • hide bottom navigation
  • accounts screen style
  • receive screen style
@NovacAndrei NovacAndrei requested a review from krisboit Dec 4, 2019
@NovacAndrei NovacAndrei changed the title Settings manage wallet, reveal secret phrase Settings - manage wallet, reveal secret phrase Dec 4, 2019
src/core/theme/itheme.ts Outdated Show resolved Hide resolved
NovacAndrei added 2 commits Dec 5, 2019
- hide bottom bar
@NovacAndrei NovacAndrei requested a review from krisboit Dec 5, 2019
src/styles/colors.ts Outdated Show resolved Hide resolved
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #214 into master will decrease coverage by 0.14%.
The diff coverage is 48.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
- Coverage   46.77%   46.62%   -0.15%     
==========================================
  Files         167      167              
  Lines        2142     2151       +9     
  Branches      452      455       +3     
==========================================
+ Hits         1002     1003       +1     
- Misses       1135     1143       +8     
  Partials        5        5
Flag Coverage Δ
#unittests 46.62% <48.14%> (-0.15%) ⬇️
Impacted Files Coverage Δ
src/screens/view-wallet-mnemonic/styles.ts 0% <ø> (ø) ⬆️
src/core/i18n/translation/locales/en.ts 100% <ø> (ø) ⬆️
...c/screens/account/components/view-key/view-key.tsx 7.14% <ø> (ø) ⬆️
src/styles/themes/dark-theme.ts 100% <ø> (ø) ⬆️
.../create-wallet-mnemonic/create-wallet-mnemonic.tsx 89.65% <ø> (ø) ⬆️
src/screens/account/components/view-key/styles.ts 0% <ø> (ø) ⬆️
src/screens/receive/styles.ts 100% <ø> (ø) ⬆️
src/screens/create-wallet-mnemonic/styles.ts 100% <ø> (ø) ⬆️
src/styles/colors.ts 100% <ø> (ø) ⬆️
src/screens/settings/settings.tsx 78.12% <0%> (-3.7%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8de03f...7ec1f5e. Read the comment docs.

@NovacAndrei NovacAndrei requested a review from krisboit Dec 5, 2019
@krisboit krisboit merged commit 25430c7 into master Dec 5, 2019
7 of 8 checks passed
7 of 8 checks passed
Run checks
Details
codecov/changes 1 file has unexpected coverage changes not visible in diff.
Details
codecov/patch 48.14% of diff hit (target 0%)
Details
codecov/project 46.62% (target 0%)
Details
security/snyk - android/app/build.gradle (Moonlet) No manifest changes detected
security/snyk - android/app/build.gradle (krisboit) No manifest changes detected
security/snyk - android/build.gradle (Moonlet) No manifest changes detected
security/snyk - package.json (Moonlet) No manifest changes detected
@krisboit krisboit deleted the settings-manage-wallet branch Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.