You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue is a low priority for now, but I have written up my findings since this may be important later to #151.
While testing #606, I noticed that many of the templates have mixed spaces and tabs for indents.
I would like to have the indentation be consistent so that we are not introducing indent issues that may annoy users later. Since #606 improved how indents are handled, this may not matter much if the user is only working in Moonshine. However, if the code is used in other editors, this can cause the code to not be lined up as expected.
Also, when we are ready to implement the indent configuration for #151, it will be helpful if the indents are standardized.
Here is a quick command I used to find the files that have space indentation or mixed indentation. Note that this may have catch some cases where mixed tabs and spaces are expected like when we are lining up html attributes split across multiple lines (although this case is one of the reasons not to use tabs).
cd Moonshine-IDE/ide/MoonshineSharedCore/src/elements/templates/
egrep -r -l "^\t* " .
In many editors, it will be difficult to spot the mismatches. Here is a Vim script that you can use to highlight the problematic indents:
set tabstop=4
let @/="\\(^\\t*\\)\\@<= \\+"
set hls
Save this text to a file like ~/.vim/HighlightSpaceIndent.vim. Then, you can import the settings into an existing Vim instance by typing ":source ~/.vim/HighlightSpaceIndent.vim" and hitting Enter.
This issue is a low priority for now, but I have written up my findings since this may be important later to #151.
While testing #606, I noticed that many of the templates have mixed spaces and tabs for indents.
I would like to have the indentation be consistent so that we are not introducing indent issues that may annoy users later. Since #606 improved how indents are handled, this may not matter much if the user is only working in Moonshine. However, if the code is used in other editors, this can cause the code to not be lined up as expected.
Also, when we are ready to implement the indent configuration for #151, it will be helpful if the indents are standardized.
Here is a quick command I used to find the files that have space indentation or mixed indentation. Note that this may have catch some cases where mixed tabs and spaces are expected like when we are lining up html attributes split across multiple lines (although this case is one of the reasons not to use tabs).
For example:
The text was updated successfully, but these errors were encountered: