-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Version Number for SDKs #39
Comments
I'm closing this as fixed. |
I saw some version numbers that didn't match up to the actual versions. I need to investigate this a bit more. |
Could you shed some more details on that @JoelProminic ? Have you seen this for some specific sdks ? |
Hmm, I think I discussed this with @rat-moonshine in private chats. I think at least some of the oddities I saw were because of issues with my Terminal environment. I'll revisit this when I have a chance. |
I checked the latest MSDKI build, and I don't see the version numbers listed. Are these changes still in a branch? My original concern was because the version numbers did not match up in Moonshine, MSDKI, and Terminal checks. I think we figured out that some of these discrepancies were my mistake, but I'd like to revisit this. |
Yeah.. these were part of the updates to JDK-11 branch. |
This is on master ? |
Since JDK-11 branch merged now, so yes I believe this also merged into 'master'. |
I confirmed this on the nightly build. We also took some steps to resolve the concerns I had about some of the version numbers, so I'm going to close the issue now. |
While discussing the OpenJDK changes (#38), we had the idea to display the configured version number for each SDK in the UI. By my understanding, we already use these version numbers to check if an update is required.
This could be added in the parenthesis with the SDK size:
Example:
The text was updated successfully, but these errors were encountered: