Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Version Number for SDKs #39

Closed
JoelProminic opened this issue Mar 3, 2021 · 9 comments
Closed

Show Version Number for SDKs #39

JoelProminic opened this issue Mar 3, 2021 · 9 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@JoelProminic
Copy link
Contributor

While discussing the OpenJDK changes (#38), we had the idea to display the configured version number for each SDK in the UI. By my understanding, we already use these version numbers to check if an update is required.

This could be added in the parenthesis with the SDK size:

SDK Name (Version, Size)

Example:

Apache Flex SDK (4.16.1, 983 MB)

@JoelProminic JoelProminic added the enhancement New feature or request label Mar 3, 2021
@JoelProminic JoelProminic added this to the v3.7.0 milestone Mar 3, 2021
rat-moonshine added a commit that referenced this issue Mar 4, 2021
- Changed existing JDK to download JDK11
- Added new Java Development feature
- Added version number to entries
(#39, #38)
@rat-moonshine
Copy link
Collaborator

I'm closing this as fixed.

@JoelProminic
Copy link
Contributor Author

I saw some version numbers that didn't match up to the actual versions. I need to investigate this a bit more.

@JoelProminic JoelProminic reopened this Mar 17, 2021
@piotrzarzycki21
Copy link
Collaborator

I saw some version numbers that didn't match up to the actual versions. I need to investigate this a bit more.

Could you shed some more details on that @JoelProminic ? Have you seen this for some specific sdks ?

@JoelProminic
Copy link
Contributor Author

Hmm, I think I discussed this with @rat-moonshine in private chats. I think at least some of the oddities I saw were because of issues with my Terminal environment. I'll revisit this when I have a chance.

@JoelProminic
Copy link
Contributor Author

I checked the latest MSDKI build, and I don't see the version numbers listed. Are these changes still in a branch?

My original concern was because the version numbers did not match up in Moonshine, MSDKI, and Terminal checks. I think we figured out that some of these discrepancies were my mistake, but I'd like to revisit this.

@rat-moonshine
Copy link
Collaborator

Are these changes still in a branch?

Yeah.. these were part of the updates to JDK-11 branch.

@piotrzarzycki21
Copy link
Collaborator

This is on master ?

@rat-moonshine
Copy link
Collaborator

This is on master ?

Since JDK-11 branch merged now, so yes I believe this also merged into 'master'.

@JoelProminic
Copy link
Contributor Author

I confirmed this on the nightly build. We also took some steps to resolve the concerns I had about some of the version numbers, so I'm going to close the issue now.

@piotrzarzycki21 piotrzarzycki21 modified the milestones: v3.7.0, v3.8.0 May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

3 participants