chore: Improve RocksDB File Manager implementation #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation, use the kvdb_memorydb instead
…te, both used for running File Storage tests in sequence instead of in parallel.
links234
approved these changes
Jul 2, 2024
| @@ -42,35 +42,14 @@ fn open_or_creating_rocksdb(db_path: String) -> io::Result<Database> { | |||
| } | |||
|
|
|||
| /// Storage backend for RocksDB. | |||
| pub struct StorageDb<Hasher> { | |||
| pub struct StorageDb<T> { | |||
| pub db: Arc<dyn KeyValueDB>, | |||
There was a problem hiding this comment.
Can this dyn be removed somehow or is it overcomplicating too much?
…g file storage and forest storage
…thod to use partial root
…thod from RocksDbFileStorage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 2 of #96, continuing the implementation of RocksDB with some improvements:
Backend<T>trait, which was created so we could use aMockStorageDbin unit tests for File and Forest managers. Now we usekvdb_memorydb::InMemoryinstead, which makes the code simpler.RwLock<_>from the File Storage.nextest.tomlconfig file, along with theserial_testcrate, both used to run theFileStoragetests in sequence instead of in parallel.