Fix drag issues #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moosems
added
bug
|
Fixes #4 |
rdbende
reviewed
Apr 15, 2023
(Noticed yesterday)
rdbende
reviewed
Apr 17, 2023
|
We need to get movement events happening outside of the line numbers to be passed to it. |
|
|
… into click-drag-bugs
@rdbende If I exit the Line Numbers it stops getting that specific event. |
Merged
|
A better form of the select code can be found here. However, at this point in time, I have been unable to port it properly. I will give it another try tonight and see how I do. Any results will be provided. If none are given, assume I met my old friend Failure again and give me a few days before I attempt it again. |
Correct tkinter Linux installation instructions for 2023
Broken release
Co-authored-by: Akuli <akuviljanen17@gmail.com>
@Akuli Can you look over the documentation for me and provide any comments? Should I add a section explaining the redraw() function and how it is to be used?
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Add color choosing
@rdbende A bit better. Need to be shortened but they could help out.
mtik00
reviewed
May 9, 2023
tklinenums/tklinenums.py
Outdated
| # The scroll events passed by MacOS are different from Windows and Linux | ||
| # so it must to be rectified to work properly when dealing with the events. | ||
| # Originally found here: https://stackoverflow.com/a/17457843/17053202 | ||
| return -delta if system() == "Darwin" else delta / 120 |
There was a problem hiding this comment.
I like this much better than the global; good call!
|
I should probably redo the off screen method as it likes kinda messy in retrospect. |
* set x and y from B1-Motion as original tcl text does * removed check_side_scroll as it's unnecessary * fixed select_text to highlight from clicked position to dragged position * ported logic for out of widget drag - text_auto_scan
fixed drag issues
|
All bugs are fixed. Time to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix:
.in_widget_select_mouse_drag():Textwidget it highlights kinda weirdly until back inTkLineNumsTkLineNumberswidget (left or right) and keep dragging, sel is not addedFighting between
.in_widget_select_mouse_drag()and.mouse_off_screen_scroll().Unknown origin (either in
.in_widget_select_mouse_drag(),.mouse_off_screen_scroll(), or.select_text()):TkLineNumberswidget (left or right) and keep dragging up or down, the following issues occur:Video of no-scrolling issue outside of line numbers issue:
Screen.Recording.2023-04-21.at.12.37.52.PM.mov
Video of left-right dragging fast movement issue:
Screen.Recording.2023-04-19.at.7.39.40.PM.mov
Video and image of drag exit issue:
Screen.Recording.2023-04-21.at.12.34.35.PM.mov