Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely disable specifying host type and implementation. #9

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

Mooshua
Copy link
Owner

@Mooshua Mooshua commented Aug 11, 2023

Hosts should be in a completely undefined state after being used by the container, so having this extra functionality really doesn't make sense. This is a pretty big breaking change throughout the API.

Now hosts have the somewhat subtle requirement of having a parameterless injector. Adding an extra check to throw a warning before runtime might be ideal.

Hosts should be in a completely undefined state after being used by the container, so having this extra functionality really doesn't make sense.
This is a pretty big breaking change throughout the API.
@Mooshua Mooshua merged commit 5cc9a02 into dev Aug 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant