This repository has been archived by the owner on Jan 17, 2024. It is now read-only.
Replace NSTimer with CADisplayLink and segue with dismissViewController #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not recommended to use NSTimer for animations and other UI updates. Use CADisplayLink instead. Also to reverse view controller presentation you should use an unwind segue or dismissViewController not a forward segue as it will instantiate a new view controller and repeated initialization of view controllers can lead to memory warning/termination or suboptimal performance.