Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] bob erase - do not delete non empty installation_location directory #211

Open
kisuryoza opened this issue May 18, 2024 · 2 comments · May be fixed by #218
Open

[Feature] bob erase - do not delete non empty installation_location directory #211

kisuryoza opened this issue May 18, 2024 · 2 comments · May be fixed by #218

Comments

@kisuryoza
Copy link

kisuryoza commented May 18, 2024

Currently bob erase erases directories associated with bob.

When in config user sets installation_location = /home/user/.local/bin in order to have nvim among with other user's binaries, he does not expect the whole bin directory to be erased.

I suggest that after bob erase, only nvim should be deleted if the directory it is in is not empty. Or ask the user for confirmation of deleting the whole directories.

@MordechaiHadad MordechaiHadad linked a pull request Jun 10, 2024 that will close this issue
@MordechaiHadad
Copy link
Owner

@kisuryoza created a new PR, could you test it and tell me if this is what u wanted?

kisuryoza added a commit to kisuryoza/bob that referenced this issue Jun 12, 2024
@kisuryoza
Copy link
Author

kisuryoza commented Jun 12, 2024

No but here's what I wanted #220. I tested it with default/custom installation paths and it works as I wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants