Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RedisPipeline Results Ergonomics #28

Closed
Mordil opened this issue Mar 29, 2019 · 1 comment
Closed

Improve RedisPipeline Results Ergonomics #28

Mordil opened this issue Mar 29, 2019 · 1 comment

Comments

@Mordil
Copy link
Collaborator

Mordil commented Mar 29, 2019

Right now - the RedisPipeline.execute() method resolves [RESPValue] - but this creates an unwieldy API compared to how RedisClient in general behaves.

In enqueue(operation:) the eventual resolves value is just ignored and discarded - but it would be nice to be able to capture the type information to somehow instead return [RESPValueEncodable] or have a way to grab in a reliable, non-optional, type-safe way the actual return values from the RedisClient interface so that it's consistent.

Right now, commands like zpopmax(from:max:) have a relatively complex response structure that users of RedisPipeline are left to figure out themselves, lest we just expose our helper method _mapSortedSetResponse(_:scoreIsFirst:)

@Mordil
Copy link
Collaborator Author

Mordil commented May 1, 2019

As part of PR #36 RedisPipeline has been removed from NIORedis.

At a later point, a batching API could be explored again - but it is being left up to higher level libraries at this time.

@Mordil Mordil closed this as completed May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant