sched: Add k8s scheduler support #72
Conversation
There was a problem hiding this comment.
Few style things:
- we do not use relative imports (sometime we do use relative import as in "from . import x" but for "from ... import x" - rather from treadmill.utils import x.
we do not import classes, just packages.
from treadmill.utils import X # bad
from treadmill import utils # good
utils.X()
...
this is rather big and ambitious change. can you summarize the intent separate from code - either in the comment or detailed commit message (apologies if i missed it).
if the two commits can be squashed into one, i think it will help and make review easier.
I am vacation right now, so my replies are rather sporadic. I will try and make a better / substantial review once I am back next week.
Thanks,
Andrei
| def __init__(self, zkclient, cellname, events_dir=None): | ||
| def __init__(self, zkclient, cellname, | ||
| scheduler_vendor='native', config=None, events_dir=None): | ||
| if scheduler_vendor == 'k8s': |
There was a problem hiding this comment.
If we have multiple vendors, then this should be an Enum
There was a problem hiding this comment.
Regardless, it shoudl be a global variable.
There was a problem hiding this comment.
Yeah, it is a good suggestion, I will update soon.
|
Hi, all. I will update the code soon to fix:
And I will write the details about this PR in a few days and post in this issue :) Thanks for your review. |
Signed-off-by: Ce Gao <ce.gao@outlook.com>
gaocegege
force-pushed
the
scheduler/k8s
branch
from
db7a399
to
fb56932
Compare
gaocegege
changed the title
gaocegege
changed the title
|
Closing it since it is stale |
No description provided.