New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sched: Add k8s scheduler support #72

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@gaocegege
Contributor

gaocegege commented Jul 26, 2017

No description provided.

@andreikeis

Few style things:

  • we do not use relative imports (sometime we do use relative import as in "from . import x" but for "from ... import x" - rather from treadmill.utils import x.

we do not import classes, just packages.

from treadmill.utils import X # bad
from treadmill import utils # good

utils.X()

...

this is rather big and ambitious change. can you summarize the intent separate from code - either in the comment or detailed commit message (apologies if i missed it).

if the two commits can be squashed into one, i think it will help and make review easier.

I am vacation right now, so my replies are rather sporadic. I will try and make a better / substantial review once I am back next week.

Thanks,
Andrei

def __init__(self, zkclient, cellname, events_dir=None):
def __init__(self, zkclient, cellname,
scheduler_vendor='native', config=None, events_dir=None):
if scheduler_vendor == 'k8s':

This comment has been minimized.

@ebourgeois

ebourgeois Jul 31, 2017

If we have multiple vendors, then this should be an Enum

This comment has been minimized.

@ebourgeois

ebourgeois Jul 31, 2017

Regardless, it shoudl be a global variable.

This comment has been minimized.

@gaocegege

gaocegege Aug 1, 2017

Contributor

Yeah, it is a good suggestion, I will update soon.

@gaocegege

This comment has been minimized.

Contributor

gaocegege commented Aug 1, 2017

Hi, all.

I will update the code soon to fix:

  • we do not use relative imports (sometime we do use relative import as in "from . import x" but for "from ... import x" - rather from treadmill.utils import x.

  • we do not import classes, just packages.

  • If we have multiple vendors, then this should be an Enum.

And I will write the details about this PR in a few days and post in this issue :)

Thanks for your review.

*: Add k8s scheduler
Signed-off-by: Ce Gao <ce.gao@outlook.com>

@gaocegege gaocegege changed the title from sched: Add k8s scheduler support to WIP: sched: Add k8s scheduler support Aug 6, 2017

@gaocegege gaocegege changed the title from WIP: sched: Add k8s scheduler support to sched: Add k8s scheduler support Sep 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment