Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
sched: Add k8s scheduler support #72
Few style things:
- we do not use relative imports (sometime we do use relative import as in "from . import x" but for "from ... import x" - rather from treadmill.utils import x.
we do not import classes, just packages.
from treadmill.utils import X # bad
from treadmill import utils # good
this is rather big and ambitious change. can you summarize the intent separate from code - either in the comment or detailed commit message (apologies if i missed it).
if the two commits can be squashed into one, i think it will help and make review easier.
I am vacation right now, so my replies are rather sporadic. I will try and make a better / substantial review once I am back next week.
I will update the code soon to fix:
And I will write the details about this PR in a few days and post in this issue :)
Thanks for your review.