Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #351

Merged
merged 5 commits into from May 1, 2021
Merged

Update deps #351

merged 5 commits into from May 1, 2021

Conversation

jimman2003
Copy link
Contributor

Just run cargo update

@jimman2003 jimman2003 changed the title Update locked deps(Cargo) Update locked deps(Cargo.lock) May 1, 2021
@Morganamilo
Copy link
Owner

Can you also upgrade the deps?

@jimman2003
Copy link
Contributor Author

jimman2003 commented May 1, 2021

Sure thing.. But there is an issue with the update.. if I remember correctly..working on it

@jimman2003
Copy link
Contributor Author

Here:

pb.set_prefix(&base.to_string());

@jimman2003
Copy link
Contributor Author

error e0716...Should I fix it by removing the borrow?

@Morganamilo
Copy link
Owner

If that fixes it sure. I'm not aware of what how the new version differs.

@jimman2003 jimman2003 changed the title Update locked deps(Cargo.lock) Update deps May 1, 2021
@jimman2003 jimman2003 marked this pull request as draft May 1, 2021 21:11
@jimman2003 jimman2003 marked this pull request as ready for review May 1, 2021 21:17
@jimman2003
Copy link
Contributor Author

Done!

@Morganamilo
Copy link
Owner

It looks like you're doing this all by one. You should install cargo-edit and use that.

@jimman2003
Copy link
Contributor Author

Thanks for the advice..

@jimman2003
Copy link
Contributor Author

OK..cargo-edit confirmed the deps are up-to-date

@Morganamilo Morganamilo merged commit 753d870 into Morganamilo:master May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants