Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ko_kr.json #140

Merged
merged 7 commits into from Jan 31, 2024
Merged

Update ko_kr.json #140

merged 7 commits into from Jan 31, 2024

Conversation

Hu-Myo
Copy link
Contributor

@Hu-Myo Hu-Myo commented Dec 20, 2023

I've just confirmed that it's been added
I've finished updating, can you merge it?

@MoriyaShiine
Copy link
Owner

Looks like there's conflicts, can you see what's up with that?

@Hu-Myo
Copy link
Contributor Author

Hu-Myo commented Dec 26, 2023

I rewrote it from scratch using en-us.json
I guess it's because it's different from my fork's en-us.json?

I don't think there's anything else except for the part I changed to Korean, but did I make a mistake?
I don't know how to use github, so I don't know why the conflicts happened.

@Hu-Myo
Copy link
Contributor Author

Hu-Myo commented Dec 26, 2023

Oh, there are some big changes.
There were some mistranslations, so I corrected them, saw what was added and deleted in the en-us.json, translated it back from the en-us.json, pasted it in, and there were conflicts.

I added it to "enchancement.midnightconfig" and I thought it would be weird if I translated this part, so I fixed it back to English, but can you check it?
I think you can assume I just updated it.

Comment on lines 131 to 153
"enchancement.midnightconfig.disallowedEnchantments": "허용된 Enchantments",
"enchancement.midnightconfig.invertedList": "반전된 리스트",
"enchancement.midnightconfig.overhaulEnchantingTable": "정밀한 마법 부여대",
"enchancement.midnightconfig.allowTreasureEnchantmentsInEnchantingTable": "마법 부여대에서 보물 마법 허용",
"enchancement.midnightconfig.enchantmentLimit": "마법 부여 한도",
"enchancement.midnightconfig.singleLevelMode": "단일 레벨 모드",
"enchancement.midnightconfig.allowInfinityOnCrossbows": "쇠뇌에 무한 인챈트 허용",
"enchancement.midnightconfig.allTridentsHaveLoyalty": "삼지창에 충성 자동 적용(삼지창 자동 회수)",
"enchancement.midnightconfig.channelingIgnitesOnMelee": "집전을 근거리에서 점화(번개 근거리 소환)",
"enchancement.midnightconfig.channelingWorksWhenNotThundering": "집전 발동시 천둥 제거(번개 제거 효과는 그대로 적용)",
"enchancement.midnightconfig.fireAspectWorksAsFlintAndSteel": "발화를 부싯돌과 부시처럼 사용",
"enchancement.midnightconfig.freeEnchantedBookMerging": "마법이 부여된 책 비용 무료",
"enchancement.midnightconfig.luckOfTheSeaHasLure": "바다의 행운에 미끼 포함",
"enchancement.midnightconfig.negateEnderPearlDamage": "엔더 진주 피해 무효화",
"enchancement.midnightconfig.safeChanneling": "집전 피해 무효화(집전으로 인한 번개 데미지 무효)",
"enchancement.midnightconfig.tridentsReturnFromVoid": "삼지창이 공허로 떨어져도 돌아옴",
"enchancement.midnightconfig.weakerFireAspect": "약한 발화",
"enchancement.midnightconfig.weakerGoldenApple": "약한 황금 사과",
"enchancement.midnightconfig.weakerPotions": "약한 물약",
"enchancement.midnightconfig.weaponEnchantmentCooldownRequirement": "무기 마법 부여 쿨타임 요구",
"enchancement.midnightconfig.maxExtractingBlocks": "섬세한 채굴에 대한 최대 블록 갯수",
"enchancement.midnightconfig.maxLumberjackBlocks": "벌목꾼에 대한 최대 블록 갯수",
"enchancement.midnightconfig.maxLumberjackHorizontalLength": "벌목꾼에 대한 최대 가로 길이",
Copy link
Contributor Author

@Hu-Myo Hu-Myo Dec 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recover translations for accurate communication

"entity.enchancement.ice_shard": "얼음 조각",
"entity.enchancement.brimstone": "혈사",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistranslations

"entity.enchancement.amethyst_shard": "자수정 조각",
"entity.enchancement.torch": "횟불",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typos

@@ -1,115 +1,157 @@
{
"entity.enchancement.frozen_player": "플레이어",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistranslations

Comment on lines 8 to 17
"enchantment.minecraft.infinity.desc.redirect": "활이나 쇠뇌에 일반 화살을 제한 없이 발사할 수 있습니다. 화살을 제한 없이 발사하려면 최소 화살 한개를 가지고 있어야 합니다.",
"enchantment.minecraft.channeling.desc.redirect_melee": "폭풍우가 치는동안 삼지창이 번개를 소환합니다. 근접 공격시 대상에게 화염 피해를 입힙니다.",
"enchantment.minecraft.channeling.desc.redirect_thunderless": "삼지창을 던져 대상에게 맞추면, 번개를 소환합니다.",
"enchantment.minecraft.channeling.desc.redirect_melee_thunderless": "삼지창을 던져 대상에게 맞추면, 번개를 소환합니다. 근접 공격시 대상에게 화염 피해를 입힙니다.",
"enchantment.minecraft.luck_of_the_sea.desc.redirect": "낚시할때 보물을 얻을 확률이 증가하고 낚싯바늘을 다시 건들일때까지 걸리는 시간을 줄입니다.",
"enchantment.minecraft.unbreaking.desc.redirect": "내구도가 줄어들 확률을 줄입니다.",
"advancements.adventure.two_birds_one_arrow.description.redirect": "쇠뇌를 이용하여 한방에 두마리의 팬텀을 처치하세요",
"enchantment.enchancement.assimilation": "비상식량",
"enchantment.enchancement.assimilation.desc": "음식이 채워주는 배고픔 수치만큼 배 고플때 음식을 자동으로 먹습니다. (Off Hand) 슬롯에 음식을 들고 있을 경우 이 음식만 먹게 됩니다. 음식과 음료의 소비 속도가 50% 빨라집니다."
"enchantment.enchancement.perception": "통찰",
"enchantment.enchancement.perception.desc": "어둠 속에서의 가시성을 높힙니다. 벽 너머에 있는 16블록 이내의 대상을 볼 수 있습니다.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed what was written

"enchancement.midnightconfig.title": "Enchancement",
"enchancement.midnightconfig.allowedEnchantments": "허용된 Enchancement",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed what was written

Comment on lines 91 to 95
"enchancement.midnightconfig.overhaulEnchantingTable": "마법 부여대 오버홀",
"enchancement.midnightconfig.allowTreasureEnchantmentsInEnchantingTable": "마법 부여대에서 보물 인챈트 허용",
"enchancement.midnightconfig.experienceLevelCost": "필요한 경험치 레벨 비용",
"enchancement.midnightconfig.lapisLazuliCost": "필요한 청금석 갯수",
"enchancement.midnightconfig.singleEnchantmentMode": "단일 인챈트 모드",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistranslations

"enchancement.midnightconfig.singleLevelMode": "단일 레벨 모드",
"enchancement.midnightconfig.allowInfinityOnCrossbows": "쇠뇌에 무한 인챈트 허용",
"enchancement.midnightconfig.allTridentsHaveLoyalty": "삼지창에 충성 자동 적용(삼지창 자동 회수)",
"enchancement.midnightconfig.channelingIgnitesOnMelee": "집전을 근거리에서 점화(번개 근거리 소환)",
"enchancement.midnightconfig.channelingWorksWhenNotThundering": "집전 발동시 천둥 제거(번개 제거 효과는 그대로 적용)",
"enchancement.midnightconfig.fireAspectWorksAsFlintAndSteel": "발화를 부싯돌과 부시처럼 사용",
"enchancement.midnightconfig.freeEnchantedBookMerging": "마법이 부여된 책 비용 무료화",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typos

"enchancement.midnightconfig.luckOfTheSeaHasLure": "바다의 행운에 미끼 포함",
"enchancement.midnightconfig.negateEnderPearlDamage": "엔더 진주 피해 무효화",
"enchancement.midnightconfig.safeChanneling": "집전 피해 무효화(집전으로 인한 번개 데미지 무효)",
"enchancement.midnightconfig.tridentsReturnFromVoid": "삼지창이 공허로 떨어져도 돌아옴",
"enchancement.midnightconfig.weakerFireAspect": "약한 발화",
"enchancement.midnightconfig.weakerGoldenApple": "약한 황금 사과",
"enchancement.midnightconfig.weakerPotions": "약한 포션",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistranslations

Comment on lines -112 to -110
"enchancement.midnightconfig.maxLumberjackBlocks": "벌목에 대한 최대 블록 갯수",
"enchancement.midnightconfig.maxLumberjackHorizontalLength": "벌목에 대한 최대 가로 길이",
"enchancement.midnightconfig.unbreakingChangesFlag": "내구성 변경 Flag"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistranslations

"enchancement.midnightconfig.unbreakingChangesFlag": "Unbreaking Changes Flag",
"enchancement.midnightconfig.enchantmentDescriptions": "Enchantment 설명",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recover translations for accurate communication

@MoriyaShiine
Copy link
Owner

There have been a lot of changes since this PR was made, can you please update all of the entries

1월 31일 13:10 UTC에 완료됨
Completed on 31 January at 13:10 UTC
@Hu-Myo
Copy link
Contributor Author

Hu-Myo commented Jan 31, 2024

I've just updated, can you confirm?

@MoriyaShiine
Copy link
Owner

Seems to be everything, thanks!

@MoriyaShiine MoriyaShiine merged commit 177df3d into MoriyaShiine:main Jan 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants