Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixes related to the openzeppelin audit #28

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Conversation

FedokDL
Copy link
Collaborator

@FedokDL FedokDL commented Apr 3, 2024

L-01 Lack of Input Validation
the _layerZeroEndpoint and _minter addresses are never validated.

  1. _layerZeroEndpoint validates on deploy on @layerzerolabs/lz-evm-oapp-v2/contracts/oapp/OAppCore.sol:30
  2. Added validation for _minter.

L-02 Incorrect Docstring
Fixed

N-01 Missing Docstring
Documentation is done in the interface to the smart contract. We will not make changes here.

N-02 Lack of Security Contact.
No change.

Other:

@FedokDL FedokDL self-assigned this Apr 3, 2024
@FedokDL FedokDL merged commit 187d8a4 into main Apr 19, 2024
@FedokDL FedokDL deleted the fix/openzeppelin-audit branch April 19, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants