MOROFT audit fixes #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding N01: Missing Docstrings, add a comment on mint function stating that only minter role should be able to call it.
Additionally, I believe there has been a confusion on the where the docstrings should be, we wanted to have the docstring in IMOROFT interface referenced in the MOROFT contract, with an additional comment on the mint functionality.
I don't see the need of removing docstrings from the interface which is done in this PR: https://github.com/MorpheusAIs/SmartContracts/pull/29/files#diff-7df3d98a493a8bcb1628ca6472bcf17af9f8efd67896f7db463a9a713a669358
The best way to move forward is to have the docstrings in the interface and let the inherting contracts inherit the docstrings, any additional information on function implementations should be present in the docstrings of the inheriting contract. This is not a high priority finding so I will leave it up to your team to decide how you want to proceed with this.