Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change morpho_isfalse #125

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Change morpho_isfalse #125

merged 1 commit into from
Apr 8, 2022

Conversation

softmattertheory
Copy link
Contributor

Into a regular function. This avoids a possible bug/C violation, fixing #118

Into a regular function. This avoids a possible bug/C violation.
@softmattertheory
Copy link
Contributor Author

@ConduitDan can you check this works on your end? I have tested with Ubuntu in the VM, and I want to make sure that it works for you too. Note that you need to turn off NANBOXING; I kept it on for consistency.

@ConduitDan
Copy link
Collaborator

OK built without nanboxing and all tests are passing on my machine!

Copy link
Collaborator

@ConduitDan ConduitDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find here

@ConduitDan ConduitDan merged commit 14523eb into main Apr 8, 2022
@ConduitDan ConduitDan deleted the bug118 branch April 13, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants