Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example "xlsx2adoc" #11

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

mschnell1
Copy link
Contributor

@mschnell1 mschnell1 commented Apr 19, 2024

issue #10

Copy link
Contributor Author

@mschnell1 mschnell1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MortalreminderPT trying to create a pull request

@mschnell1 mschnell1 marked this pull request as draft April 19, 2024 12:05
@mschnell1 mschnell1 changed the title initial commit example "xlsx2adoc" Apr 19, 2024
@MortalreminderPT
Copy link
Owner

It looks like your code is not passing workflow and you can see the log in action.
But perhaps I can explain why for you. To ensure the accuracy of each example, I asked it in workflow to execute all .rs file under examples.
One possible solution is that you could integrate both mods created all together in the xlsx2adoc.rs

@MortalreminderPT MortalreminderPT marked this pull request as ready for review April 19, 2024 14:20
@MortalreminderPT MortalreminderPT changed the base branch from main to dev-0.4 April 19, 2024 14:37
@MortalreminderPT MortalreminderPT merged commit a0aec90 into MortalreminderPT:dev-0.4 Apr 19, 2024
1 check failed
@MortalreminderPT
Copy link
Owner

I merged your example into the dev-0.4 branch and then I'll fix this little problem.
Thank you for your contribution to this project.😉

@mschnell1
Copy link
Contributor Author

mschnell1 commented Apr 19, 2024

I merged your example into the dev-0.4 branch and then I'll fix this little problem. Thank you for your contribution to this project.😉

Great !
I intended to ask if it's even appropriate to use multiple files in an example..
I guess it's not.

@MortalreminderPT
Copy link
Owner

I merged your example into the dev-0.4 branch and then I'll fix this little problem. Thank you for your contribution to this project.😉
Great !
I intended to ask if it's even appropriate to use multiple files in an example..
I guess it's not.

Yep you can use all the xlsx files under tests/xlsx, if examples gets complicated in the future maybe I'll need to split it into simple and complex examples later on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants