Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check which adapters can tweak projection instead of comparison #138

Closed
Morwenn opened this issue Dec 3, 2018 · 1 comment
Closed

Check which adapters can tweak projection instead of comparison #138

Morwenn opened this issue Dec 3, 2018 · 1 comment
Milestone

Comments

@Morwenn
Copy link
Owner

Morwenn commented Dec 3, 2018

Sorters that can take a custom comparison function can implicitly take a projection function too, so sorter adapters can be more widely used if they tweak the behaviour of the projection function instead of that of the comparison function.

It looks like at least indirect_adapter can benefit from such an improvement. Implement that and check whether other sorter adapters can also take advantage of that.

@Morwenn
Copy link
Owner Author

Morwenn commented Dec 4, 2018

Apparently indirect_adapter was the only one that could actually be improved: scwhartzian_adapter already uses the projection while it seems hard to remove the comparison in stable_adapter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant