Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-cl support #208

Closed
Morwenn opened this issue Sep 18, 2022 · 1 comment
Closed

clang-cl support #208

Morwenn opened this issue Sep 18, 2022 · 1 comment
Labels
tooling
Milestone
1.13.2

Comments

@Morwenn
Copy link
Owner

Morwenn commented Sep 18, 2022

Considering what I have been told about clang-cl, I am pretty sure that cpp-sort doesn't properly work with it nowadays. Try to use it, and fix the library as needed.
Morwenn added a commit that referenced this issue Oct 5, 2022
@Morwenn
Fix __int128_t handling with clang-cl (#208)
3b65a69 
So far cpp-sort that any standard library that had __SIZEOF_INT128__
defined was either libc++ or libstdc++. However it turned out that
clang-cl provides that type but targets the Microsoft STL, so our
internal family of is_integral traits had to be updated to take that
new information into account.
@Morwenn Morwenn added this to the 1.13.2 milestone Oct 6, 2022
@Morwenn
Copy link
Owner Author

Morwenn commented Oct 6, 2022

Fixing an issue with __[u]int128_t introduced in 1.13.1 was surprisingly enough to get clang-cl to build modulo a few (hundreds of) warnings. Most of the platform-specific #ifdef in the library were surprisingly ordered the correct way to make everything work, which is as lucky as I get.

I added a Debug clang-cl build to CI, but the corresponding Release build crashes during the compilation process. The error makes it look like a memory issue, and it does compile and run locally so I'm pretty positive that it's a CI-only issue and not an issue on the library side.

@Morwenn Morwenn closed this as completed Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tooling
Projects
None yet
Milestone
1.13.2
Development

No branches or pull requests
1 participant
@Morwenn