Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Payment failure dev #206

Merged
merged 42 commits into from
Mar 11, 2024
Merged

Payment failure dev #206

merged 42 commits into from
Mar 11, 2024

Conversation

arkanoider
Copy link
Collaborator

Hi @grunch ,

some improvement for failure.
Didi another branch for a cleare situation.
Removed your println, not tested because of office.

Give a shot if you can

@arkanoider arkanoider closed this Mar 1, 2024
@arkanoider arkanoider reopened this Mar 1, 2024
@grunch grunch mentioned this pull request Mar 2, 2024
Closed
@arkanoider
Copy link
Collaborator Author

This should make the trick.

Basically when entering in do_payment we had still Active state in the order, not SettledHoldInvoice. This was due to the fact that we saved in db, but variable order is not updated, force a read from db gets the right state.

Still to align case "issue" :)

arkanoider and others added 17 commits March 8, 2024 08:37
@arkanoider
Merge pull request #4 from grunch/payment-failure-dev
a70ce54 
Replace hardcoded string comparison and fixes
@arkanoider
addded some println! to debug status order
3d22b5c
@arkanoider
addded also some order id println!
7ce85bb
@grunch
Ugly hack to wait for the update to be persisted
20d9d6c
@arkanoider
Merge pull request #5 from grunch/payment-failure-dev
de17f45 
Ugly hack to wait for the update to be persisted
@grunch
Implement kebab case
ad7e6f2
@arkanoider
Merge pull request #6 from grunch/payment-failure-dev
b55f05d 
Implement kebab case
@grunch
Use a more realistic time until db data is saved
37ecbd6
@arkanoider
Merge pull request #7 from grunch/payment-failure-dev
056d260 
Use a more realistic time until db data is saved
@arkanoider
negrunch testing failure no sleep
7e24eef
@arkanoider
some more improvements to avoid possible CRUD overwrite
ac4dda1
@arkanoider
small cosmetic
cc4edb3
@arkanoider
moved db connection inside failure fn
727841e
@arkanoider
removed println and fixed payment_success fn to user updated order st…
0ec53ad 
…atus
@arkanoider
Merge branch 'negrunch-test' into payment-failure-dev
f3bc75e
@arkanoider
Merge branch 'MostroP2P:main' into payment-failure-dev
25967ed
@arkanoider
Added 2 missing order update status
ee5eaba
grunch
grunch approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@grunch grunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after 42 commits LGTM 🚀

congrats buddy @arkanoider

@grunch grunch merged commit ed3f0f0 into MostroP2P:main Mar 11, 2024
1 check passed
@arkanoider arkanoider mentioned this pull request Mar 12, 2024
Closed
@arkanoider arkanoider deleted the payment-failure-dev branch March 13, 2024 07:47
@grunch grunch mentioned this pull request Mar 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grunch grunch grunch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arkanoider @grunch