Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handles message parsing error & prints an error log #294

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

bilthon
Copy link
Contributor

@bilthon bilthon commented May 29, 2024

Without this mostro just silently rejects malformed or out of date messages from clients without even an error log entry.

Copy link
Collaborator

@arkanoider arkanoider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it's a merge without lookin, good to have more log on error in these case.

@bilthon
Copy link
Contributor Author

bilthon commented Jun 2, 2024

Perhaps more could be done, like sending a CantDo message to the client. But logging it was the minimal thing I could think of and that as an operator can help you understand what happened and why the client's message got dropped.

@arkanoider
Copy link
Collaborator

Perhaps more could be done, like sending a CantDo message to the client. But logging it was the minimal thing I could think of and that as an operator can help you understand what happened and why the client's message got dropped.

I agree 100%

Copy link
Member

@grunch grunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grunch grunch merged commit 6f54ceb into MostroP2P:main Jun 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants