Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add destroy animation #56

Merged
merged 8 commits into from
Nov 2, 2018
Merged

Add destroy animation #56

merged 8 commits into from
Nov 2, 2018

Conversation

rechtburg
Copy link
Contributor

@rechtburg rechtburg commented Oct 31, 2018

関連Issue

要件

破壊モーションをつける

詳細

それに付随して、project-pageのリコンストラクト

orbit_pos を変更したのは、firstはご存知の通り、ActiveRecordにすでに存在するからです。
これらを同意のラテン語に変更しました。
それに伴い、システム内の全nameをそれに統一しました。

対象ページ

特にレビューしてほしいところ

・stateの使い方
・ライフサイクル関数内での処理
・コンポーネント化した部分(/molecules配下)

その他

要因install
npm install --dev-save animejs

@rechtburg rechtburg self-assigned this Oct 31, 2018
@rechtburg rechtburg added enhancement New feature or request design set/fix design In progress In progress labels Oct 31, 2018
@rechtburg rechtburg changed the title Add destroy animation [WIP] Add destroy animation Oct 31, 2018
app/models/assignment.rb Outdated Show resolved Hide resolved
Copy link
Member

@bokusunny bokusunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

とりあえずざっと気になったところだけコメントしました

frontend/src/javascripts/components/molecules/planet.js Outdated Show resolved Hide resolved
db/seeds.rb Outdated Show resolved Hide resolved
frontend/src/javascripts/components/molecules/popup-box.js Outdated Show resolved Hide resolved
frontend/src/javascripts/components/molecules/planet.js Outdated Show resolved Hide resolved
frontend/src/javascripts/components/users/project-page.js Outdated Show resolved Hide resolved
frontend/src/javascripts/components/users/project-page.js Outdated Show resolved Hide resolved
frontend/src/javascripts/reducers/assignments.js Outdated Show resolved Hide resolved
frontend/src/javascripts/reducers/assignments.js Outdated Show resolved Hide resolved
frontend/src/javascripts/actions/assignments.js Outdated Show resolved Hide resolved
Copy link
Member

@bokusunny bokusunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuki-s-utmafia
connect直したらうまく行くかも

@rechtburg rechtburg removed the In progress In progress label Nov 2, 2018
@rechtburg rechtburg changed the title [WIP] Add destroy animation Add destroy animation Nov 2, 2018
Copy link
Member

@bokusunny bokusunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かいとこだけ!

frontend/src/javascripts/reducers/assignments.js Outdated Show resolved Hide resolved
@bokusunny bokusunny merged commit 1dea52a into master Nov 2, 2018
@bokusunny bokusunny deleted the add_destroy_animation branch November 2, 2018 10:31
@rechtburg rechtburg mentioned this pull request Nov 5, 2018
bokusunny added a commit that referenced this pull request Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design set/fix design enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants