Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GitHub Toggle Issue Comments) Only 1 (empty) placeholder is displayed instead of the commenters avatars #20

Closed
darkred opened this issue Jun 5, 2017 · 2 comments

Comments

@darkred
Copy link
Collaborator

darkred commented Jun 5, 2017

Using 'GitHub Toggle Issue Comments' script version 1.0.26
with either GM 3.11 in Firefox 53.0.3 (even in clean profile)
or TM 4.2.7 in Chrome 58.

The issue is that no avatars are added under the Hide Comments from text:
only 1 (empty) placeholder (i.e. the <img> tag for that empty placeholder has src="undefined".)
is displayed instead.


Here is a screenshot (from an issue link example with 12 commenters ) to better show what I mean:

2017-06-05_211625

There's no error in Browser Console while this happens.
I checked the addAvatars() function
but unfortunately couldn't locate what's the cause of this.

@Mottie
Copy link
Owner

Mottie commented Jun 5, 2017

Hi @darkred!

Thanks for reporting this problem. It looks like GitHub moved the avatar class name. I'll get this fixed ASAP!

@Mottie Mottie closed this as completed in 6877146 Jun 5, 2017
@darkred
Copy link
Collaborator Author

darkred commented Jun 5, 2017

Thank you for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants