Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort file listing? #24

Closed
gingerbeardman opened this issue Jul 3, 2017 · 8 comments
Closed

Sort file listing? #24

gingerbeardman opened this issue Jul 3, 2017 · 8 comments

Comments

@gingerbeardman
Copy link

gingerbeardman commented Jul 3, 2017

Would expect it in GitHub Sort Content.

But have also checked GitHub Files Filter, no joy.

Currently I see:

screen shot 2017-07-03 at 13 27 29

@Mottie
Copy link
Owner

Mottie commented Jul 3, 2017

Hi @gingerbeardman!

I didn't include the sorting in the GitHub sort content userscript because it adds the sort arrows as a background image and the file view doesn't have a header that can be targeted. I found this userscript a while back that adds clickable arrows to allow sorting, so I didn't think it would be necessary for me to repeat the work. It's not really "pretty" though 😉.

I guess it would be a good idea to include it in the sort content script... I'll put it on my to-do list.

@gingerbeardman
Copy link
Author

@Mottie thanks for the link, sadly that still keeps folders and files separate 😭

Although easy enough to change that script once it's installed. Cheers!

Would still use your solution if you ever do one. 👍

@Mottie Mottie closed this as completed in 12096e4 Jul 4, 2017
@Mottie
Copy link
Owner

Mottie commented Jul 4, 2017

It was easier to add then I thought 😸

@gingerbeardman
Copy link
Author

@Mottie beauty! many thanks

@Mottie
Copy link
Owner

Mottie commented Jul 4, 2017

Hehe, I think it actually looks kinda ugly, but what can ya do?

@gingerbeardman
Copy link
Author

you adding it was beautiful, it looks... passable 😄

@gingerbeardman
Copy link
Author

gingerbeardman commented Jul 4, 2017

strangely, is only appears if i get to a page and reload?

if i get to a page through browsing it doesn't appear?

see screen recording:
https://transfer.sh/KKCTo/quirk.mov (valid for 14 days)

@Mottie
Copy link
Owner

Mottie commented Jul 4, 2017

Yeah, it's very fussy... the files within the table are added after the page loads, so sometimes it acts that way. I have the same issue with the file filter userscript. If you look at the bottom of the code, you'll see this block:

		// init after a short delay to allow rendering of file list
setTimeout(() => {
  addRepoFileThead();
}, 200);

Try increasing the 200 ms a little bit and see if that helps. I'll keep searching for a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants