Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GitHub Toggle Issue Comments) In some issue pages, there's an unneeded "1 hidden (from hidden comments)" when 'GitHub Sort Reactions' is also installed #57

Closed
darkred opened this issue Sep 22, 2018 · 2 comments
Labels

Comments

@darkred
Copy link
Collaborator

darkred commented Sep 22, 2018

Hi again dear @Mottie

Unfortunately I just found another issue:
in some issue pages I tried,
when both "GitHub Toggle Issue Comments" and "GitHub Sort Reactions" are installed,
there's a unneeded 1 hidden (from hidden comments) under the first post

STR

  • with a fresh Chrome browser profile with only TM 4.8.5850 beta and scripts GTIC 1.23 and GSR 0.2.6
  • open either
    https://github.com/Microsoft/vscode/issues/58712 or https://github.com/Microsoft/vscode/issues/59142
  • make sure that only the "+1 Comments" filter in GTIC is active:
    notice that in both URLs, when you click it, it becomes "+1 Comments (1 hidden)".
    but there's no comment actually hidden (there's no "+1" comment to hide)
  • notice that there's a 1 hidden (from hidden comments) under the first post.
  • If you disable GSR, then the issue no longer occurs.
@darkred darkred changed the title (GitHub Toggle Issue Comments) In some pages, there's an unneeded "1 hidden (from hidden comments)" when 'GitHub Sort Reactions' is also installed (GitHub Toggle Issue Comments) In some issue pages, there's an unneeded "1 hidden (from hidden comments)" when 'GitHub Sort Reactions' is also installed Sep 22, 2018
@Mottie Mottie closed this as completed in 50ca1e9 Sep 23, 2018
@Mottie
Copy link
Owner

Mottie commented Sep 23, 2018

Hi @darkred!

Yeah, the count was from the sort reactions block that was added by the sort reactions userscript. I actually ended up updating both the sort reactions and issue comments userscripts to fix this. Please let me know if you encounter any issues.

@Mottie Mottie added the bug label Sep 23, 2018
@darkred
Copy link
Collaborator Author

darkred commented Sep 23, 2018

It's working fine now. Thanks a lot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants