Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

调整 Dockerfile 以及 Bison 的运行方式 #447

Merged
merged 3 commits into from
Feb 11, 2024
Merged

调整 Dockerfile 以及 Bison 的运行方式 #447

merged 3 commits into from
Feb 11, 2024

Conversation

AzideCupric
Copy link
Collaborator

删除了 bot.py,现在可以以nb run运行

Copy link

netlify bot commented Dec 25, 2023

Deploy Preview for nonebot-bison ready!

Name Link
🔨 Latest commit 15d76a9
🔍 Latest deploy log https://app.netlify.com/sites/nonebot-bison/deploys/65c8b81cc74828000852bb4b
😎 Deploy Preview https://deploy-preview-447--nonebot-bison.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 25, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f6ee4a4) 82.53% compared to head (f37a1ef) 82.53%.
Report is 7 commits behind head on main.

❗ Current head f37a1ef differs from pull request most recent head 15d76a9. Consider uploading reports for the commit 15d76a9 to get more accurate results

Files Patch % Lines
nonebot_bison/plugin_config.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #447   +/-   ##
=======================================
  Coverage   82.53%   82.53%           
=======================================
  Files          64       64           
  Lines        3246     3253    +7     
=======================================
+ Hits         2679     2685    +6     
- Misses        567      568    +1     
Flag Coverage Δ
smoke-test 82.53% <87.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

RUN python3 -m pip config set global.index-url https://mirrors.aliyun.com/pypi/simple
RUN python3 -m pip install poetry && poetry config virtualenvs.create false
WORKDIR /app
COPY ./pyproject.toml ./poetry.lock* /app/
RUN poetry install --no-root --no-dev
COPY ./README.md ./pyproject.toml ./poetry.lock* /app/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个怎么加进来了

@AzideCupric AzideCupric changed the base branch from main to fix/prettier-trailing-comma January 26, 2024 14:14
@AzideCupric
Copy link
Collaborator Author

新的commit9837692 解决了docker webui缺失的问题,但是对于为什么env读取不到还是没有头猪

Base automatically changed from fix/prettier-trailing-comma to main January 29, 2024 03:00
@AzideCupric AzideCupric mentioned this pull request Feb 10, 2024
@felinae98
Copy link
Collaborator

rebase 一下?然后默认还是 command 不需要 / 吧

@@ -29,5 +31,16 @@ def outer_url(self) -> str:
class Config:
extra = "ignore"

@root_validator(pre=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

能不能把 .docker.env.prod 里直接写上默认值,这里就不搞这个了

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以 昨晚就说改了(

@AzideCupric AzideCupric changed the title 🔧 调整 Dockerfile 以及 Bison的运行方式 🔧 调整 Dockerfile 以及 Bison 的运行方式 Feb 11, 2024
@felinae98 felinae98 merged commit 1a96d31 into main Feb 11, 2024
32 checks passed
@felinae98 felinae98 deleted the next branch February 11, 2024 13:48
@felinae98 felinae98 added the enhancement New feature or request label Feb 11, 2024
@felinae98 felinae98 changed the title 🔧 调整 Dockerfile 以及 Bison 的运行方式 调整 Dockerfile 以及 Bison 的运行方式 Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants