Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

更详细的微博 #504

Merged
merged 5 commits into from
Mar 25, 2024
Merged

更详细的微博 #504

merged 5 commits into from
Mar 25, 2024

Conversation

LambdaYH
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for nonebot-bison ready!

Name Link
🔨 Latest commit f2e7da8
🔍 Latest deploy log https://app.netlify.com/sites/nonebot-bison/deploys/65fd42a76755db000893d207
😎 Deploy Preview https://deploy-preview-504--nonebot-bison.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LambdaYH LambdaYH changed the title 更详细的微博 ✨ 更详细的微博 Mar 19, 2024
@AzideCupric AzideCupric added the enhancement New feature or request label Mar 19, 2024
nonebot_bison/platform/weibo.py Outdated Show resolved Hide resolved
tests/platforms/test_weibo.py Outdated Show resolved Hide resolved
and (url.startswith("https://weibo.cn/sinaurl?u=") or url.startswith("https://video.weibo.com"))
):
url = unquote(url.replace("https://weibo.cn/sinaurl?u=", ""))
elem.text = f"{elem.text}({url} )"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
elem.text = f"{elem.text}({url} )"
elem.text = f"{elem.text}({url})"

是不是多了个空格(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果没空格,')'容易被当作链接的一部分识别(

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那要不前后都加空格吧,为了对称)

@AzideCupric
Copy link
Collaborator

repost现在还不会渲染,测试可能过不了,你等我开一个pr修一下(乐

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 85.36585% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 83.50%. Comparing base (3d4dca3) to head (f2e7da8).
Report is 1 commits behind head on main.

Files Patch % Lines
nonebot_bison/platform/weibo.py 85.36% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
+ Coverage   83.48%   83.50%   +0.01%     
==========================================
  Files          78       78              
  Lines        3543     3564      +21     
==========================================
+ Hits         2958     2976      +18     
- Misses        585      588       +3     
Flag Coverage Δ
smoke-test 83.50% <85.36%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AzideCupric
Copy link
Collaborator

repost现在还不会渲染,测试可能过不了,你等我开一个pr修一下(乐

可以 rebase 一下 main 分支了,这样前端构建应该就不会炸了

@felinae98
Copy link
Collaborator

能够获取到视频微博的视频 cover 吗

@felinae98 felinae98 changed the title ✨ 更详细的微博 更详细的微博 Mar 25, 2024
@felinae98 felinae98 merged commit 3683d3e into MountainDash:main Mar 25, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants