为B站动态API建立model，转发动态放入repost字段 #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nonebot-bison ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fix/pyd-compat #507 +/- ##
==================================================
+ Coverage 83.50% 83.66% +0.15%
==================================================
Files 78 78
Lines 3565 3636 +71
==================================================
+ Hits 2977 3042 +65
- Misses 588 594 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
felinae98
reviewed
Mar 26, 2024
nonebot_bison/platform/bilibili.py
Outdated
Comment on lines
250
to
277
| if in_repost and raw_origin: | ||
| url = f"https://t.bilibili.com/{raw_origin.dynamic_id_str}" | ||
| else: | ||
| url = f"https://t.bilibili.com/{raw_post.desc.dynamic_id_str}" | ||
| text: str = card_content["item"]["description"] | ||
| pic: list[str] = [img["img_src"] for img in card_content["item"]["pictures"]] | ||
| return ParsedPost(text, pic, url, repost_owner) | ||
| case 2: |
There was a problem hiding this comment.
这里为什么不像原来那样分为 _get_info 和 parse 两个函数了
There was a problem hiding this comment.
因为原来两个函数里都是按category分支看起来很啰嗦，感觉不如合成一个
There was a problem hiding this comment.
但是这里写了4便if repose，看起来还是可以简化的那种
There was a problem hiding this comment.
...
def extract_id(name: str):
if in_repost and raw_origin:
return getattr(raw_origin, name)
return getattr(raw_post.desc, name)
match self._do_get_category(raw_post.desc.type):
case 1:
# 一般动态
url = f"https://t.bilibili.com/{extract_id('dynamic_id_str')}"
...这样呢（
Open
AzideCupric
force-pushed
the
fix/bilibili-none
branch
from
ea5e76e
to
81f252a
Compare
|
先合并前置的 #512 |
felinae98
approved these changes
Mar 29, 2024
felinae98
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.