Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable manually remove bad channels? #139

Closed
babaq opened this issue Nov 15, 2019 · 9 comments · Fixed by #595
Closed

enable manually remove bad channels? #139

babaq opened this issue Nov 15, 2019 · 9 comments · Fixed by #595

Comments

@babaq
Copy link

babaq commented Nov 15, 2019

Just encounter the situation that some bad channels could be obviously observed when recording, and also when referencing externally, all internal referencing channels are grounded. those channels IDs could be send to KS, so that KS could escape those channels when it start to deciding bad channels, or set them as bad channels anyway after it finished finding bad channels.

I can't find a way to set it right now, and would be trivial to add ops.badch and do it in preprocessDataSub.

any thought? @marius10p

@nsteinme
Copy link
Collaborator

nsteinme commented Nov 15, 2019 via email

@babaq
Copy link
Author

babaq commented Nov 15, 2019

yes, i am using matlab functions, and find the ops.chanMap only holding the path to the chanmap files, the loading part and find bad channels are all in the preprocessDataSub function. I could try to do a quick pull request, adding lines you suggested.

@nsteinme
Copy link
Collaborator

nsteinme commented Nov 15, 2019 via email

@babaq
Copy link
Author

babaq commented Nov 15, 2019

found that loadChanMap could handle loaded chanMap.

Thanks

@babaq babaq closed this as completed Nov 15, 2019
@babaq babaq reopened this Nov 15, 2019
@babaq
Copy link
Author

babaq commented Nov 15, 2019

is it correct to just set the bad channels in ops.chanMap.connected to 0?

@nsteinme
Copy link
Collaborator

nsteinme commented Nov 15, 2019 via email

@babaq
Copy link
Author

babaq commented Nov 15, 2019

ok, I saw that in preprocessDataSub the total number of channels in chanmap has a chance to overwrite the ops.NchanTOT if it's missing, I am wandering if I removed some bad channels from chanmap, and result in e.g. 269 channels, but the bin file saved all the 384 channels, I should still set ops.NchanTOT=384, or I should leave it unset outside , so it will be set automatically in preprocessDataSub to 269?

@marius10p
Copy link
Contributor

ops.NchanTOT is just the total number of channels in your raw data file.

ops.Nchan gets set by the algorithm after removing bad channels, and is the total number of sorted channels.

@babaq
Copy link
Author

babaq commented Nov 25, 2019

Got it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants